[FIX] LearnerScorer: fix for preprocessed data#3381
Merged
lanzagar merged 1 commit intobiolab:masterfrom Nov 12, 2018
Merged
Conversation
Feature scoring with learners did not work if the data was previously preprocessed (for example with PCA).
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #3381 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 354 354
Lines 63291 63291
=======================================
Hits 52012 52012
Misses 11279 11279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ranking with a Scores did not work if the data was preprocessed with PCA (or anything else). Saving and loading the data (and thus obtaining primitive features) helped.
Description of changes
Search for original attributes in score-joining function used to go all the way up to primitive features. Now it stops when it comes to a feature from the input data.
Includes