Skip to content

[FIX] setup.py: Remove trailing slash from directory names in data_files#3394

Merged
lanzagar merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/setup-data-files
Nov 13, 2018
Merged

[FIX] setup.py: Remove trailing slash from directory names in data_files#3394
lanzagar merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/setup-data-files

Conversation

@ales-erjavec
Copy link
Contributor

Issue

Running python setup.py bdist_wheel with sphinx installed on windows results in:

...
ValueError: path 'share/help/en/orange3/htmlhelp/' cannot end with '/'
Description of changes
  • Avoid trailing slash in directory names in data_files
Includes
  • Code changes
  • Tests
  • Documentation

On windows distutils `install_data` rejects such names.
No longer needed since Python 3.4 was removed form the test matrix
@lanzagar lanzagar added this to the 3.18 milestone Nov 13, 2018
@lanzagar lanzagar merged commit 746eb0d into biolab:master Nov 13, 2018
@ales-erjavec ales-erjavec deleted the fixes/setup-data-files branch May 20, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants