[FIX]t-SNE: Generate temporary projection data#3454
Merged
pavlin-policar merged 1 commit intobiolab:masterfrom Dec 8, 2018
Merged
[FIX]t-SNE: Generate temporary projection data#3454pavlin-policar merged 1 commit intobiolab:masterfrom
pavlin-policar merged 1 commit intobiolab:masterfrom
Conversation
| Domain(self.data.domain.attributes, | ||
| self.data.domain.class_vars, | ||
| self.data.domain.metas + self.projection.domain.attributes)) | ||
| self.data.domain.metas + variables)) |
Collaborator
There was a problem hiding this comment.
So if I got this right, you're just adding the two t-SNE variables with empty values until the embedding is actually computed and populated with the actual embedding values. That seems all right.
Ideally, you wouldn't even need to draw anything until the embedding finishes, but I don't know how hard that may be to implement...
Collaborator
|
Fixes the issue. Will merge once as the tests pass. |
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
+ Coverage 83.26% 83.28% +0.01%
==========================================
Files 365 365
Lines 64306 64316 +10
==========================================
+ Hits 53547 53563 +16
+ Misses 10759 10753 -6 |
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
+ Coverage 83.26% 83.27% +<.01%
==========================================
Files 365 365
Lines 64306 64317 +11
==========================================
+ Hits 53547 53562 +15
+ Misses 10759 10755 -4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3452
Description of changes
Includes