util.get_unique_names: Add more flexible arguments#3486
Merged
thocevar merged 3 commits intobiolab:masterfrom Jan 4, 2019
Merged
util.get_unique_names: Add more flexible arguments#3486thocevar merged 3 commits intobiolab:masterfrom
thocevar merged 3 commits intobiolab:masterfrom
Conversation
janezd
force-pushed
the
improve-get-unique-names
branch
2 times, most recently
from
069d61f to
fb4b645
Compare
Codecov Report
@@ Coverage Diff @@
## master #3486 +/- ##
==========================================
+ Coverage 83.55% 83.57% +0.01%
==========================================
Files 367 368 +1
Lines 65454 65491 +37
==========================================
+ Hits 54691 54731 +40
+ Misses 10763 10760 -3 |
Codecov Report
@@ Coverage Diff @@
## master #3486 +/- ##
==========================================
- Coverage 83.51% 83.51% -0.01%
==========================================
Files 367 368 +1
Lines 65599 65618 +19
==========================================
+ Hits 54787 54802 +15
- Misses 10812 10816 +4 |
janezd
force-pushed
the
improve-get-unique-names
branch
3 times, most recently
from
56219ff to
9ffd963
Compare
janezd
force-pushed
the
improve-get-unique-names
branch
from
9ffd963 to
9910f89
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Orange.data.util.get_unique_namesaccept a list of used names. When we call it, we almost always have a domain. Let the function accept a domain, too.While at it, the second argument could also be a string, not a list of strings.
While at it, write some tests.
Fixes #3495, too.
Includes