Skip to content

[FIX] Neighbours: Show error when data and reference have different domain.#3547

Merged
janezd merged 2 commits intobiolab:masterfrom
PrimozGodec:fix-neighbour-chrashes
Jan 24, 2019
Merged

[FIX] Neighbours: Show error when data and reference have different domain.#3547
janezd merged 2 commits intobiolab:masterfrom
PrimozGodec:fix-neighbour-chrashes

Conversation

@PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Jan 23, 2019

Issue

Neighbours chrashes when data and reference has different domains.

Description of changes

It shows an error instead of a crash now.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3547 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3547      +/-   ##
==========================================
+ Coverage   83.78%   83.79%   +<.01%     
==========================================
  Files         370      370              
  Lines       66680    66717      +37     
==========================================
+ Hits        55871    55905      +34     
- Misses      10809    10812       +3

@PrimozGodec PrimozGodec force-pushed the fix-neighbour-chrashes branch from 86f64ad to 539832d Compare January 23, 2019 13:21
@PrimozGodec PrimozGodec changed the title [WIP][FIX] Neighbours: Show error when data and reference have different domain. [FIX] Neighbours: Show error when data and reference have different domain. Jan 23, 2019
@janezd janezd merged commit 89d3cc9 into biolab:master Jan 24, 2019
@PrimozGodec PrimozGodec deleted the fix-neighbour-chrashes branch January 25, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants