[FIX] Warning about a window title without a placeholder#3554
Merged
janezd merged 1 commit intobiolab:masterfrom Jan 28, 2019
Merged
[FIX] Warning about a window title without a placeholder#3554janezd merged 1 commit intobiolab:masterfrom
janezd merged 1 commit intobiolab:masterfrom
Conversation
Contributor
|
The warning in gh-3267 probably comes from CanvasMainWindow not OWWidget. That uses windowFilePath. Maybe try: diff --git a/Orange/canvas/application/canvasmain.py b/Orange/canvas/application/canvasmain.py
index 4d0cee46c..500100a80 100644
--- a/Orange/canvas/application/canvasmain.py
+++ b/Orange/canvas/application/canvasmain.py
@@ -230,7 +230,7 @@ class CanvasMainWindow(QMainWindow):
frame.setWidget(self.scheme_widget)
# Window 'title'
- self.setWindowFilePath(self.scheme_widget.path())
+ self.setWindowFilePath(self.scheme_widget.path() or " ")
self.scheme_widget.pathChanged.connect(self.setWindowFilePath)
self.scheme_widget.modificationChanged.connect(self.setWindowModified)
|
Contributor
Author
|
You're right. |
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
- Coverage 83.96% 83.95% -0.01%
==========================================
Files 370 370
Lines 66876 66876
==========================================
- Hits 56152 56146 -6
- Misses 10724 10730 +6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3267
Description of changes
Append "[*]" placeholder to the window title (if it's not already present) before calling setWindowTitle.
Includes