Added settingsAboutToBePacked signal to OWWidget#3567
Merged
janezd merged 2 commits intobiolab:masterfrom Feb 15, 2019
Merged
Conversation
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 83.97% 83.97% -0.01%
==========================================
Files 370 370
Lines 66941 66969 +28
==========================================
+ Hits 56215 56237 +22
- Misses 10726 10732 +6 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 83.97% 83.97% -0.01%
==========================================
Files 370 370
Lines 66941 66969 +28
==========================================
+ Hits 56215 56237 +22
- Misses 10726 10732 +6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
storeSpecificSettings is only called with a ContextHandler. Also, it is called after packing normal settings and before packing context settings.
In #3529 I implemented a special SettingsHandler because I needed to prepare settings for saving just before saving them.
Then I tried, in #3541, to extend (store|retrieve)SpecificSettings to an ordinary SettingsHandler. I failed: they were designed and used in a way that I could not make them work with ordinary settings (and not break stuff).
Before, I thought making storeSpecificSettings would be easy and would not change the interface. But now the question is if something like this is useful enough to extend the OWWidget with. I only needed something like this twice.
Description of changes
Added a signal settingsAboutToBePacked.
Includes