Merged
Conversation
lanzagar
reviewed
Feb 11, 2019
| self.pca_preprocessing() | ||
|
|
||
| # Dirty flag indicating whether the embedding has been drawn at least once | ||
| self.needs_to_draw = True |
Contributor
There was a problem hiding this comment.
This can probably be removed now. In any case the comment is no longer true.
Collaborator
Author
There was a problem hiding this comment.
This cannot be removed because, at the start of the optimization, we have to draw something, so we just draw some random points, because the graph widget needs some data to be shown. However, we'd like to replace this random data with something slightly more meaningful as soon as possible, so setting this to True here will ensure that after the first batch of iterations is done, the widget will display something better than random data.
bac2463 to
914588c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3592 +/- ##
==========================================
+ Coverage 83.98% 83.98% +<.01%
==========================================
Files 370 370
Lines 66976 66984 +8
==========================================
+ Hits 56249 56256 +7
- Misses 10727 10728 +1 |
pavlin-policar
pushed a commit
to pavlin-policar/orange3
that referenced
this pull request
Feb 11, 2019
[FIX] t-SNE speed-ups
pavlin-policar
pushed a commit
to pavlin-policar/orange3
that referenced
this pull request
Feb 11, 2019
[FIX] t-SNE speed-ups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
t-SNE was slow
Description of changes
transformwas being called. Avoid this.Includes