[FIX] OWTable: Include attributes from meta attributes in header row labels#3633
Merged
markotoplak merged 1 commit intobiolab:masterfrom Mar 5, 2019
Merged
Conversation
07ddbf9 to
035666d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3633 +/- ##
==========================================
+ Coverage 84.31% 84.32% +<.01%
==========================================
Files 370 370
Lines 67838 67850 +12
==========================================
+ Hits 57197 57213 +16
+ Misses 10641 10637 -4 |
Member
|
This is certainly a fix of the point (2) in #2777. But you decided that you won't fix the point (1), right? |
Contributor
Author
|
I didn't decide, I just overlooked it. :) But if I didn't overlook it, I still wouldn't implement it. I think it doesn't hurt to have this information there. If we however decide to remove it, we can easily do this by renaming "color" to "_color". What's your opinion? And @BlazZupan, @brunap, others? |
Member
|
@janezd, I am against hiding "color". I have no opinion about "_color". |
Contributor
Author
|
If you're against hiding, that's it. We would rename it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2777
Includes