[FIX] VizRankDialog: Use extended thread pool to prevent segfaults#3669
Merged
ales-erjavec merged 1 commit intobiolab:masterfrom Mar 18, 2019
Merged
[FIX] VizRankDialog: Use extended thread pool to prevent segfaults#3669ales-erjavec merged 1 commit intobiolab:masterfrom
ales-erjavec merged 1 commit intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
==========================================
+ Coverage 84.43% 84.48% +0.05%
==========================================
Files 372 373 +1
Lines 68087 68188 +101
==========================================
+ Hits 57488 57609 +121
+ Misses 10599 10579 -20 |
de3c95c to
80a1748
Compare
Contributor
|
I get various or if I Pause/Continue multiple time during a run then let it run till the end in Correlations widget (testing on phoneme.tab). |
Contributor
Author
|
I just realized these asserts should be removed because an exception can occur while computing the score and therefore is not put into the table. |
When fed large datasets, correlations widget exited with segmentation fault, (probably) due to insufficient stack size for created task.
Contributor
|
Might I suggest just setting a larger initial stack size on the QThread instance, then maybe revisit this latter. I think the ConcurrentMixin is not a good fit for this, at least as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When fed large datasets to owcorrelations, the widget exited with segmentation fault, (probably) due to insufficient stack size for created task.
To reproduce: Generate a dataset with at least 26 features and 3361 rows, and feed it to OWCorrelations.
Description of changes
Includes