Skip to content

[FIX] Compatibility with Logitech's Smart Move#3702

Merged
ales-erjavec merged 2 commits intobiolab:masterfrom
thocevar:smartmove
Apr 1, 2019
Merged

[FIX] Compatibility with Logitech's Smart Move#3702
ales-erjavec merged 2 commits intobiolab:masterfrom
thocevar:smartmove

Conversation

@thocevar
Copy link
Contributor

Issue

Fixes #3294, #3598

Description of changes

Logitech's Smart Move option moves the mouse pointer to a focused item after opening a new window.

A double-click triggers two mouse press events and a double-click event between them. After the widget window opens, Smart Move triggers a mouse move event. A typical event sequence is [press, release, double click, press, move, release], which results in a relocation of the widget's node on canvas (moved while pressed).

The solution is to ignore the second press event if it is too close (closer than doubleClickInterval) to the previous one.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #3702 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
+ Coverage   84.52%   84.52%   +<.01%     
==========================================
  Files         373      373              
  Lines       68391    68391              
==========================================
+ Hits        57805    57806       +1     
+ Misses      10586    10585       -1

@janezd janezd requested a review from ales-erjavec March 29, 2019 15:00
@ales-erjavec ales-erjavec merged commit 31a9c08 into biolab:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orange3 widgets move around

2 participants