[FIX] Minor improvements to pythagorean trees#3777
Merged
thocevar merged 6 commits intobiolab:masterfrom May 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
+ Coverage 85.04% 85.06% +0.01%
==========================================
Files 374 374
Lines 69111 69142 +31
==========================================
+ Hits 58776 58816 +40
+ Misses 10335 10326 -9 |
Contributor
|
There is a problem with the settings of Pythagorean trees that come from a forest. For example, you can set the depth of a tree to 1, then select a different tree and the visualization does not match the depth setting. Similar situation arises when you change the data. The depth is set to the context-aware value but is not reflected in the visualization. |
b052335 to
57d4ecc
Compare
Collaborator
Author
|
@thocevar This issue should now be resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes a couple of minor things I came across while reviewing #3775.
The tree widget does not currently remember selection (both when reopening a workflow or when redrawing), and this will be a bit trickier to implement, since Orange trees have no identifier for each node.
Includes