[ENH] Reset settings button#3795
Merged
markotoplak merged 5 commits intobiolab:masterfrom May 31, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3795 +/- ##
==========================================
+ Coverage 84.76% 84.76% +<.01%
==========================================
Files 374 374
Lines 69148 69172 +24
==========================================
+ Hits 58616 58637 +21
- Misses 10532 10535 +3 |
Member
|
This restores last saved widget settings well. It should probably reset the settings to the defaults. |
Member
|
@janezd, I added some tests. While I was writing them, pycharm suggested that I use resetSettings(), which seems to do something very similar to _reset_settings. Which one should we keep? |
Contributor
Author
I would remove |
Method didn't really reset them (it reverted them to the saved state, not the original), it wasn't used (except in a single place where it was unnecessary) and, worst of all, its name was in camel case. I believe the world is better without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3564.
It would be nice if every widget had a reset settings button. This must be implemented specifically for each widget.
This PR prepares the GUI and implements the functionality for a single widget. If widget implements a method named
reset_setting, a reset button will appear and call this method.reset_settingswill usually be simple: it mustself._reset_settings),The icons is passable but could be improved upon. For one thing, it is a bit too large.
Includes