Merged
Conversation
VesnaT
force-pushed
the
owpivot
branch
3 times, most recently
from
6463cb7 to
97b491a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3823 +/- ##
==========================================
+ Coverage 85.06% 85.22% +0.16%
==========================================
Files 374 376 +2
Lines 69148 70112 +964
==========================================
+ Hits 58821 59755 +934
- Misses 10327 10357 +30 |
VesnaT
force-pushed
the
owpivot
branch
2 times, most recently
from
7417e69 to
c441019
Compare
janezd
approved these changes
May 31, 2019
| def __reference_aggregations(self, var_indep_funs, var_dep_funs): | ||
| self._indepen_agg_done = {} | ||
| self._depen_agg_done = defaultdict(dict) | ||
| i = 1 - int(bool(self.single_var_grouping)) |
Contributor
There was a problem hiding this comment.
bool is derived from int, there's no need to cast to int.
| def __get_group_table(self, var, var_indep_funs, var_dep_funs, attrs): | ||
| if var is self._total_var: | ||
| group_tab = self._group_tables.total | ||
| offset = int(bool(not self.single_var_grouping)) |
Contributor
There was a problem hiding this comment.
I wouldn't cast this, neither.
| (~np.isnan(self._col_var_col)))[0]] | ||
| elif var is self._row_var or self.single_var_grouping: | ||
| group_tab = self._group_tables.total_v | ||
| offset = int(bool(not self.single_var_grouping)) |
Contributor
There was a problem hiding this comment.
You can skip int(bool(...)). Operator not already gives a bool which is a subclass of int.
ajdapretnar
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Add pivot widget.
Implements #2860
Description of changes
Includes