Skip to content

[FIX] DBSCAN: Fix predicted labels#3833

Merged
lanzagar merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-dbscan
May 31, 2019
Merged

[FIX] DBSCAN: Fix predicted labels#3833
lanzagar merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-dbscan

Conversation

@PrimozGodec
Copy link
Contributor

Issue

DBSCAN has wrong mapping of indices when make a Table. The first class is maped at -1 group, -1 is a group for nonclustered items.

Description of changes

There will be a complete fix when #3814 will be merged. Since it will take some time I am proposing a quick fix.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #3833 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3833   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         374      374           
  Lines       69148    69148           
=======================================
  Hits        58821    58821           
  Misses      10327    10327

@lanzagar lanzagar changed the title DBSCAN: fix indices and tests [FIX] DBSCAN: Fix predicted labels May 31, 2019
@lanzagar lanzagar merged commit fce05b8 into biolab:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants