[ENH] Shared namespaces for PythonScript widgets#3840
Merged
markotoplak merged 2 commits intobiolab:masterfrom May 31, 2019
Merged
[ENH] Shared namespaces for PythonScript widgets#3840markotoplak merged 2 commits intobiolab:masterfrom
markotoplak merged 2 commits intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3840 +/- ##
==========================================
+ Coverage 84.77% 84.77% +<.01%
==========================================
Files 374 374
Lines 69172 69197 +25
==========================================
+ Hits 58640 58662 +22
- Misses 10532 10535 +3 |
markotoplak
changed the title
markotoplak
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3820.
Description of changes
PythonScript widgets on the same canvas now share namespaces. Consequently, namespaces are no longer cleared after execution and garbage is not collected.
This PR also fixes a glitch in the base widget test class.
Includes