[ENH] Faster drawing in scatterplot#3871
Merged
janezd merged 3 commits intobiolab:masterfrom Jun 14, 2019
Merged
Conversation
07fc35b to
172cc19
Compare
Codecov Report
@@ Coverage Diff @@
## master #3871 +/- ##
==========================================
+ Coverage 84.97% 84.97% +<.01%
==========================================
Files 378 378
Lines 70496 70509 +13
==========================================
+ Hits 59905 59918 +13
Misses 10591 10591 |
Contributor
|
Marko, this looks great. Will this change propagate to other point-based visualizations, like in t-SNE and MDS widgets? |
Member
Author
|
@BlazZupan, it will propagate to any scatterplot-based point visualization. With how large data sets did you see a difference? |
172cc19 to
0dde1ab
Compare
Member
Author
|
@janezd, I replaced lambdas with a function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3589
Description of changes
Now adult with spots of same color, shape=occupation, size=fnlwgt displays in less than 1 second instead of 10.5s as before.
Includes