Skip to content

CSV File Import: pylint#3888

Merged
janezd merged 5 commits intobiolab:masterfrom
ales-erjavec:csv-file-import-pylint
Jun 17, 2019
Merged

CSV File Import: pylint#3888
janezd merged 5 commits intobiolab:masterfrom
ales-erjavec:csv-file-import-pylint

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue

Pylint the files added in gh-3876

Description of changes

Also fix other issues:

  • CSV File Import needs pandas as a requirement
  • One branch in TablePreviewModel.data had a missing return statement
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3888 into master will increase coverage by <.01%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master    #3888      +/-   ##
==========================================
+ Coverage   84.28%   84.28%   +<.01%     
==========================================
  Files         384      384              
  Lines       72736    72739       +3     
==========================================
+ Hits        61307    61310       +3     
  Misses      11429    11429

@janezd
Copy link
Copy Markdown
Contributor

janezd commented Jun 17, 2019

Thanks! This file really needed some cleaning up.

@janezd janezd merged commit 0ee3aa1 into biolab:master Jun 17, 2019
@ales-erjavec ales-erjavec deleted the csv-file-import-pylint branch March 16, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants