Merged
Conversation
ajdapretnar
approved these changes
Jun 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 384 384
Lines 72739 72739
=======================================
Hits 61309 61309
Misses 11430 11430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3839
Description of changes
I tried a clean install from source on Windows and it was relatively straightforward after installing the huge (>1GB) visual studio build tools. I moved the basic development info to a separate readme, where we can elaborate on any other issues.
Includes