[FIX] Change normalization to Scaling in SVM#3898
Merged
thocevar merged 6 commits intobiolab:masterfrom Jul 29, 2019
Merged
Conversation
thocevar
reviewed
Jul 19, 2019
Contributor
thocevar
left a comment
thocevar
left a comment
There was a problem hiding this comment.
The user can opt out trough a check box. Currently the check box is in the optimization parameters box, perhaps something else is needed.
I don't see this check box.
Codecov Report
@@ Coverage Diff @@
## master #3898 +/- ##
==========================================
+ Coverage 85.02% 85.02% +<.01%
==========================================
Files 378 378
Lines 66679 66705 +26
==========================================
+ Hits 56691 56715 +24
- Misses 9988 9990 +2 |
Codecov Report
@@ Coverage Diff @@
## master #3898 +/- ##
=========================================
Coverage ? 84.84%
=========================================
Files ? 371
Lines ? 65514
Branches ? 0
=========================================
Hits ? 55588
Misses ? 9926
Partials ? 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3202
Description of changes
SVM was failing because Corpus widget outputs sparse matrix which must be then turned to dense, if we want to mean shift it. We would like to avoid that, so the current proposal is to just scale the data. The user can opt out trough a check box. Currently the check box is in the optimization parameters box, perhaps something else is needed.
Includes