[FIX] Normalize: Fix crash with nan column#4125
Merged
janezd merged 1 commit intobiolab:masterfrom Oct 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
==========================================
+ Coverage 85.62% 85.62% +<.01%
==========================================
Files 388 388
Lines 69435 69436 +1
==========================================
+ Hits 59454 59455 +1
Misses 9981 9981 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Normalization crashes when data contains a feature without a value.
To reproduce: File (Iris) -> Feature Constructor (new
numericvariable with expression:nan) -> Preprocess (Normalize Features (normalize to interval))Description of changes
Feature with missing values retains missing values after normalization.
Includes