[ENH] OWBoxPlot: Show missing values#4135
Merged
ajdapretnar merged 2 commits intobiolab:masterfrom Nov 8, 2019
Merged
Conversation
janezd
reviewed
Oct 24, 2019
f4ffb71 to
95bb2bb
Compare
Contributor
|
We discussed this. Yes it would make sense to group by having/not having missing values. Good idea. |
95bb2bb to
c34c003
Compare
7b9f0fe to
1a2f65b
Compare
Codecov Report
@@ Coverage Diff @@
## master #4135 +/- ##
==========================================
+ Coverage 85.71% 85.73% +0.02%
==========================================
Files 389 389
Lines 69831 69832 +1
==========================================
+ Hits 59856 59872 +16
+ Misses 9975 9960 -15 |
30887a9 to
14d660b
Compare
14d660b to
f0fe5de
Compare
f0fe5de to
331f4cc
Compare
Contributor
Author
|
It is ready now. |
Contributor
|
Hm. This doesn't seem to work on heart_disease... 🤔 |
Contributor
Author
|
It works for me. There is a change in the Cython code. It was compiled in .c code already but it needs to be compiled again for each computer (at MacOS the result of the compilation is .so file). The easiest way to do that is by running: in the Orange folder when this PR is checked out. |
Contributor
|
Ah, important detail. 👌 Love the change! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4128
Description of changes
Includes