Skip to content

[FIX] ROC and LiftCurve: Store context settings#4138

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:list-and-roc-contexts
Nov 8, 2019
Merged

[FIX] ROC and LiftCurve: Store context settings#4138
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:list-and-roc-contexts

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented Oct 23, 2019

Issue

Fixes #4115: Lift curve and ROC Analysis did not have context settings. (Also because there was no suitable handler before #3881; #3881 implemented such a handler for the new calibration plot widget and even noticed that Lift Curve and ROC Analysis can now use it :).

Description of changes

Use EvaluationResultsContextHandler in the two widgets.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1fb5f8a). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4138   +/-   ##
=========================================
  Coverage          ?   85.67%           
=========================================
  Files             ?      389           
  Lines             ?    69677           
  Branches          ?        0           
=========================================
  Hits              ?    59694           
  Misses            ?     9983           
  Partials          ?        0

@ajdapretnar ajdapretnar merged commit 69454c8 into biolab:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lift Curve should remember the choice of target class

2 participants