Skip to content

[FIX] build-conda-installer.sh: Do not use python version from Miniconda#4142

Merged
thocevar merged 1 commit intobiolab:masterfrom
ales-erjavec:fixes/conda-installer-py-version-check
Nov 12, 2019
Merged

[FIX] build-conda-installer.sh: Do not use python version from Miniconda#4142
thocevar merged 1 commit intobiolab:masterfrom
ales-erjavec:fixes/conda-installer-py-version-check

Conversation

@ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Oct 24, 2019

Issue

Fixes gh-3830

Description of changes

Use the version from python package that will be installed and not miniconda python version for the compatibility check.

Also make Miniconda installer version configurable from the command line.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #4142 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4142   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         389      389           
  Lines       69839    69839           
=======================================
  Hits        59892    59892           
  Misses       9947     9947

@janezd
Copy link
Contributor

janezd commented Oct 25, 2019

@thocevar, can you test this on Windows? You can ask @ales-erjavec for details about what needs to be checked.

@ales-erjavec
Copy link
Contributor Author

Installer for 3.23.1 can be rebuild with this fix using:

./scripts/windows/build-conda-installer.sh --online no --env-spec /dev/stdin <<[EOF]
# This file may be used to create an environment using:
# $ conda create --name <env> --file <this file>
# platform: win-64
@EXPLICIT
https://repo.anaconda.com/pkgs/main/win-64/blas-1.0-mkl.tar.bz2#e8aa6b7daaf0925245c148aaeaa0722e
https://repo.anaconda.com/pkgs/main/win-64/ca-certificates-2019.5.15-1.tar.bz2#6623284afd2199552cd1a19465490e17
https://repo.anaconda.com/pkgs/main/win-64/icc_rt-2019.0.0-h0cc432a_1.tar.bz2#ce2949c239b5cd45848a0a7865d30520
https://repo.anaconda.com/pkgs/main/win-64/intel-openmp-2019.4-245.tar.bz2#cd40f1846d3ada9ad3cfa61ef5fa7502
https://repo.anaconda.com/pkgs/main/win-64/vs2015_runtime-14.16.27012-hf0eaf9b_0.tar.bz2#26cfb48570e77f6ee22efe4a5b67068c
https://repo.anaconda.com/pkgs/main/win-64/mkl-2019.4-245.tar.bz2#0f897fde2379b1adf2f6df4e79f22276
https://repo.anaconda.com/pkgs/main/win-64/vc-14.1-h0510ff6_4.tar.bz2#00bfe39f46f67409a376939cd2ab5039
https://repo.anaconda.com/pkgs/main/win-64/icu-58.2-ha66f8fd_1.tar.bz2#8b9a078b693623d58afd56f4f2a162c3
https://repo.anaconda.com/pkgs/main/win-64/jpeg-9b-hb83a4c4_2.tar.bz2#7abafa9f9a2c609e1b77424f5ffa6a8a
https://repo.anaconda.com/pkgs/main/win-64/openssl-1.1.1c-he774522_1.tar.bz2#3cfeb411b7add6bc2e5c83d79f80deea
https://repo.anaconda.com/pkgs/main/win-64/sqlite-3.29.0-he774522_0.tar.bz2#aa1f14ecb00c376fbb1d2c0b2700acf8
https://repo.anaconda.com/pkgs/main/win-64/yaml-0.1.7-hc54c509_2.tar.bz2#eaeee418b8ac33d392ea03bb9b6f389d
https://repo.anaconda.com/pkgs/main/win-64/zlib-1.2.11-h62dcd97_3.tar.bz2#6f96fd91475cc78aabf76d2e1a9ed91f
https://repo.anaconda.com/pkgs/main/win-64/libpng-1.6.37-h2a8f88b_0.tar.bz2#351328bf2bee7fd7ee7e9c158aeb1be2
https://repo.anaconda.com/pkgs/main/win-64/python-3.6.9-h5500b2f_0.tar.bz2#e2746e24772c27525acfff6ec154651e
https://repo.anaconda.com/pkgs/main/win-64/asn1crypto-0.24.0-py36_0.tar.bz2#a0a7514683fc72a9b8ca218c76a0f854
https://repo.anaconda.com/pkgs/main/win-64/certifi-2019.6.16-py36_1.tar.bz2#8a075241067cacc0c874aad0bdf2a313
https://repo.anaconda.com/pkgs/main/win-64/chardet-3.0.4-py36_1003.tar.bz2#bebd78e772a985545ef161879f39a5aa
https://repo.anaconda.com/pkgs/main/win-64/decorator-4.4.0-py36_1.tar.bz2#72875d63dd69455d06238094f9cd1585
https://repo.anaconda.com/pkgs/main/win-64/docutils-0.15.2-py36_0.tar.bz2#9adc73fa2f89de6697f27fedb12c3faf
https://repo.anaconda.com/pkgs/main/win-64/entrypoints-0.3-py36_0.tar.bz2#032c3c66f46872e1e01f8575d0cec8e3
https://repo.anaconda.com/pkgs/main/win-64/freetype-2.9.1-ha9979f8_1.tar.bz2#f3263f3249686ede2d2bea458e30e61f
https://repo.anaconda.com/pkgs/main/win-64/future-0.17.1-py36_0.tar.bz2#0a2ae226ce78c53e8fe74187f00fc037
https://repo.anaconda.com/pkgs/main/win-64/idna-2.8-py36_0.tar.bz2#ec1acbd73601eecdaf2f2c1a7778a4ee
https://repo.anaconda.com/pkgs/main/win-64/joblib-0.13.2-py36_0.tar.bz2#9d972c33a38b604df2df6e2f665fbf41
https://repo.anaconda.com/pkgs/main/win-64/kiwisolver-1.1.0-py36ha925a31_0.tar.bz2#aadffe2a64dd4a6f6316a617c3603610
https://repo.anaconda.com/pkgs/main/win-64/llvmlite-0.29.0-py36ha925a31_0.tar.bz2#a3ccd6b8f0a40560ee5e510f7a755d8b
https://repo.anaconda.com/pkgs/main/win-64/lockfile-0.12.2-py36h0468280_0.tar.bz2#addc9001ef950d30bb33b57a1bf28d44
https://repo.anaconda.com/pkgs/main/win-64/msgpack-python-0.6.1-py36h74a9793_1.tar.bz2#5bc6e90da51f743ea458c8fa86df5f2d
https://repo.anaconda.com/pkgs/main/win-64/pycparser-2.19-py36_0.tar.bz2#916a2d9a1840e412a60ed5c3b96a7002
https://repo.anaconda.com/pkgs/main/noarch/pyparsing-2.4.2-py_0.tar.bz2#e71678940b1dba776240d113feb6ddb3
https://repo.anaconda.com/pkgs/main/noarch/pytz-2019.2-py_0.tar.bz2#533ab7d9880501780a75781e51f53972
https://repo.anaconda.com/pkgs/main/win-64/pywin32-223-py36hfa6e2cd_1.tar.bz2#2b054becb70649e0b2207410e2513cbc
https://repo.anaconda.com/pkgs/main/win-64/pyyaml-5.1.2-py36he774522_0.tar.bz2#fc6e42a51b4af47253231ae586e5ef65
https://repo.anaconda.com/pkgs/main/win-64/qt-5.9.7-vc14h73c81de_0.tar.bz2#2c80f3edd65223da2062f84292c9eac9
https://repo.anaconda.com/pkgs/main/win-64/sip-4.19.8-py36h6538335_0.tar.bz2#90579ba294413272ffc489517a38058f
https://repo.anaconda.com/pkgs/main/win-64/six-1.12.0-py36_0.tar.bz2#31dfe13c94e5b173aa1cc3108b9f9959
https://repo.anaconda.com/pkgs/main/win-64/tornado-6.0.3-py36he774522_0.tar.bz2#449c62c770109478675095d2f13aa184
https://repo.anaconda.com/pkgs/main/win-64/win_inet_pton-1.1.0-py36_0.tar.bz2#0cdb48b6e3b8d614f3ae41a24dd0b37a
https://repo.anaconda.com/pkgs/main/win-64/wincertstore-0.2-py36h7fe50ca_0.tar.bz2#6c0c44d1a1e2d83e508dbce508c6f009
https://repo.anaconda.com/pkgs/main/win-64/xlrd-1.2.0-py36_0.tar.bz2#3aa49f5f26b2a3ee9f1c75ce93c6d6d0
https://repo.anaconda.com/pkgs/main/noarch/xlsxwriter-1.1.8-py_0.tar.bz2#3391f463c5c0a09af98995418026a249
https://repo.anaconda.com/pkgs/main/win-64/cffi-1.12.3-py36h7a1dbc1_0.tar.bz2#18b9ba8ddd5de61389f9733255d2d4c3
https://repo.anaconda.com/pkgs/main/win-64/commonmark-0.8.1-py36_0.tar.bz2#2a2642b0d16285156f5a1458a5adf38b
https://repo.anaconda.com/pkgs/main/win-64/cycler-0.10.0-py36h009560c_0.tar.bz2#5d045387250c9b55097d3be01af54b11
https://repo.anaconda.com/pkgs/main/win-64/keyring-18.0.0-py36_0.tar.bz2#12ad9676e9849c4634d9097098562623
https://repo.anaconda.com/pkgs/main/win-64/pyqt-5.9.2-py36h6538335_2.tar.bz2#7dce429c3e87f0be1196664c731852d0
https://repo.anaconda.com/pkgs/main/win-64/pysocks-1.7.0-py36_0.tar.bz2#f15e120a16604663d64f361cea807b3f
https://repo.anaconda.com/pkgs/main/win-64/python-dateutil-2.8.0-py36_0.tar.bz2#8ee8fc0f5ca164bb557bd5f650dd5d7c
https://repo.anaconda.com/pkgs/main/win-64/setuptools-41.0.1-py36_0.tar.bz2#693645f690539d33beaadf84864b0028
https://repo.anaconda.com/pkgs/main/win-64/anyqt-0.0.10-py36_0.tar.bz2#b53ee337a0ef6e6a1a90f4e880465844
https://repo.anaconda.com/pkgs/main/win-64/cryptography-2.7-py36h7a1dbc1_0.tar.bz2#76ae1e60dcae3fae5789c28cde1743f1
https://repo.anaconda.com/pkgs/main/win-64/keyrings.alt-3.1.1-py36_0.tar.bz2#385b928dd900113e35989f6279f8d15d
https://repo.anaconda.com/pkgs/main/noarch/networkx-2.3-py_0.tar.bz2#e519ecc91263aa0c0088c919871be9e7
https://repo.anaconda.com/pkgs/main/win-64/wheel-0.33.4-py36_0.tar.bz2#a5e3b816efa257d7cb0ab706a86e9a3c
https://repo.anaconda.com/pkgs/main/win-64/pip-19.2.2-py36_0.tar.bz2#6dff1a58e99103ff31a0bf807f7b4753
https://repo.anaconda.com/pkgs/main/win-64/pyopenssl-19.0.0-py36_0.tar.bz2#7ceb720c2958a66737b65b8111b406f5
https://repo.anaconda.com/pkgs/main/win-64/urllib3-1.24.2-py36_0.tar.bz2#65ff729a1dee0ba78bcc59c5ce7b3eba
https://repo.anaconda.com/pkgs/main/win-64/requests-2.22.0-py36_0.tar.bz2#5cdaa285b76b6f0110f79961c2289ed0
https://repo.anaconda.com/pkgs/main/win-64/cachecontrol-0.12.5-py36_0.tar.bz2#38375ced94a008cd91b598c5df54e6c4
https://repo.anaconda.com/pkgs/main/win-64/serverfiles-0.3.0-py36_0.tar.bz2#2fca4ecf0e16bc2ac0f7b08e3ce6db6d
https://conda.anaconda.org/conda-forge/noarch/orange-canvas-core-0.1.7-py_0.tar.bz2#48e6d5e0d7887f123cfde1354341a47d
https://repo.anaconda.com/pkgs/main/win-64/bottleneck-1.2.1-py36h452e1ab_1.tar.bz2#fee379513d73fb059196658b1f5b3446
https://repo.anaconda.com/pkgs/main/win-64/matplotlib-3.1.1-py36hc8f65d3_0.tar.bz2#0627b1a43fce6fae82f3b1f974b94f01
https://repo.anaconda.com/pkgs/main/win-64/mkl-service-2.0.2-py36he774522_0.tar.bz2#145eda338b433b6194890c69d2d785ce
https://repo.anaconda.com/pkgs/main/win-64/mkl_fft-1.0.14-py36h14836fe_0.tar.bz2#0f896fed78f53f5670c3fc119d20aae5
https://repo.anaconda.com/pkgs/main/win-64/mkl_random-1.0.2-py36h343c172_0.tar.bz2#ce1021d7aa8914e763528250e6eb795d
https://repo.anaconda.com/pkgs/main/win-64/numba-0.45.1-py36hf9181ef_0.tar.bz2#640d70e3c5d5d93ba02ff289e4cf921c
https://repo.anaconda.com/pkgs/main/win-64/numpy-1.16.4-py36h19fb1c0_0.tar.bz2#7618d95a3dfb28580389dd39ed602e43
https://repo.anaconda.com/pkgs/main/win-64/numpy-base-1.16.4-py36hc3f5095_0.tar.bz2#b6b0e46f969d7139b1d5832a38ca1005
https://repo.anaconda.com/pkgs/main/win-64/pandas-0.25.1-py36ha925a31_0.tar.bz2#9454208ed32cb8b604d73abe0110b25a
https://repo.anaconda.com/pkgs/main/win-64/pyqtgraph-0.10.0-py36h28b3542_3.tar.bz2#295ad6c168c7fe008c30a37fbbb66bf5
https://repo.anaconda.com/pkgs/main/noarch/python-louvain-0.13-py_0.tar.bz2#5e9896a094f76c87f5af222d383c8740
https://repo.anaconda.com/pkgs/main/win-64/scipy-1.2.1-py36h29ff71c_0.tar.bz2#9166703266e0b3e8bca3c4752b5a8a5a
https://conda.anaconda.org/conda-forge/noarch/orange-widget-base-4.0.1-py_0.tar.bz2#292211d3c6d53920a75a9de683d204a6
https://repo.anaconda.com/pkgs/main/win-64/scikit-learn-0.21.2-py36h6288b17_0.tar.bz2#344474303fb8e8d0d1ceb417d7a903bb
https://conda.anaconda.org/conda-forge/noarch/pynndescent-0.3.0-py_0.tar.bz2#e2c19d0298a796708c78a1381e3083d7
https://conda.anaconda.org/conda-forge/win-64/opentsne-0.3.11-py36hc8d92b1_0.tar.bz2#d917ddba007af83facc0a112f0aebbba
https://conda.anaconda.org/conda-forge/win-64/orange3-3.23.1-py36h6538335_0.tar.bz2#54ebc66c50a1c3da330110ee1b3d70e4
[EOF]

... or downloaded from here

Use the version from python package that will be installed.
Also make Miniconda installer version configurable form the
command line.
@ales-erjavec ales-erjavec force-pushed the fixes/conda-installer-py-version-check branch from 6a5a45c to 355b2f0 Compare November 11, 2019 11:53
@thocevar
Copy link
Contributor

Update on Windows from Orange 3.22 to 3.23 works smoothly with this fix.

@thocevar thocevar merged commit d998711 into biolab:master Nov 12, 2019
@ales-erjavec ales-erjavec deleted the fixes/conda-installer-py-version-check branch March 16, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows miniconda installer check for compatible environments is broken

3 participants