Skip to content

[FIX] Louvain Clustering: fix setting to restore correctly#4187

Merged
BlazZupan merged 1 commit intobiolab:masterfrom
PrimozGodec:lovain
Nov 15, 2019
Merged

[FIX] Louvain Clustering: fix setting to restore correctly#4187
BlazZupan merged 1 commit intobiolab:masterfrom
PrimozGodec:lovain

Conversation

@PrimozGodec
Copy link
Contributor

Issue

Fixes #4182, also when just chaning the dataset and changing it back settings did not restored.

Description of changes

Removed two lines that caused that settings did not restore to the old value. In my opinion, those two lines are not required since spin has the same functionality itself.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Louvain Clustering: fix setting to restore corretly [FIX] Louvain Clustering: fix setting to restore corretly Nov 13, 2019
@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #4187 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4187      +/-   ##
==========================================
+ Coverage   85.78%   85.79%   +0.01%     
==========================================
  Files         389      389              
  Lines       69871    69892      +21     
==========================================
+ Hits        59938    59965      +27     
+ Misses       9933     9927       -6

@BlazZupan BlazZupan changed the title [FIX] Louvain Clustering: fix setting to restore corretly [FIX] Louvain Clustering: fix setting to restore correctly Nov 15, 2019
@BlazZupan BlazZupan merged commit c09bb2a into biolab:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Louvian Clustering widget not saving custom k neighbours

2 participants