[ENH] Heatmap: Allow labeling by any variable#4209
Merged
ajdapretnar merged 1 commit intobiolab:masterfrom Nov 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
+ Coverage 85.95% 85.95% +<.01%
==========================================
Files 394 394
Lines 70153 70145 -8
==========================================
- Hits 60302 60296 -6
+ Misses 9851 9849 -2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4206.
Description of changes
DomainModelto get everything for free.Variableinstead of integer indices into domain.Settings cannot be migrated because they were broken. The annotation variable was stored as an index into the original domain, while context was stored based on filtered domain. The two could mismatch and settings could have been stored incorrectly, so they can't be safely migrated.
Includes