Skip to content

[FIX] owtable: Preserve tab order of updated inputs #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markotoplak merged 1 commit into from
Nov 29, 2019
Merged

[FIX] owtable: Preserve tab order of updated inputs #4225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Orange/widgets/data/owtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,16 @@ def set_dataset(self, data, tid=None):
"""Set the input dataset."""
self.closeContext()
if data is not None:
datasetname = getattr(data, "name", "Data")
if tid in self._inputs:
# update existing input slot
slot = self._inputs[tid]
view = slot.view
# reset the (header) view state.
view.setModel(None)
view.horizontalHeader().setSortIndicator(-1, Qt.AscendingOrder)
assert self.tabs.indexOf(view) != -1
self.tabs.setTabText(self.tabs.indexOf(view), datasetname)
else:
view = QTableView()
view.setSortingEnabled(True)
Expand All @@ -484,9 +487,10 @@ def sort_reset(index, order):
view.model().sort(index, order)

header.sortIndicatorChanged.connect(sort_reset)
self.tabs.addTab(view, datasetname)

view.dataset = data
self.tabs.addTab(view, getattr(data, "name", "Data"))
self.tabs.setCurrentWidget(view)

self._setup_table_view(view, data)
slot = TableSlot(tid, data, table_summary(data), view)
Expand Down