[FIX] table_to_frame: metas lost on conversion

[itslarin]

Issue

Description of changes

Includes

• Code changes
• Tests
• Documentation

[claassistantio]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #4259 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4259      +/-   ##
==========================================
+ Coverage   86.77%   86.81%   +0.03%     
==========================================
  Files         396      396              
  Lines       71550    71557       +7     
==========================================
+ Hits        62089    62121      +32     
+ Misses       9461     9436      -25

[VesnaT]

Thank you for the PR.

Some comments:

• Have you thought of adding an argument to the table_to_frame i. e. include_metas=False to ensure backward compatibility?
• Some unittests would be nice.

[itslarin]

Hi, Vesna.

Have you thought of adding an argument to the table_to_frame i. e. include_metas=False to ensure backward compatibility?

In my personal opinion this parameter can cause confusion in further usage, i believe by default table supposed to be transformed into frame without any columns lost. The user always can drop some columns explicitly if he needs. There might be some incompatibility though in case somebody rely on output frame columns number (maybe in tests). Otherwise i guess additional (in comparison with prev. results) datarfame columns shouldnt provide any harm to existing code.

[VesnaT]

All that is true and I agree with you, but still, the existing code should not be broken.
Nobody knows how many add-ons are using the function, all expecting dataframes without metas.
If you don't like the additional parameter, you can add it temporarily and raise a deprecation warning, to allow users to fix their code. The parameter can be removed in the next version.

[janezd]

... in the next version

Or a year. Better.

[janezd]

Decision at the meeting: @VesnaT implements what she proposed here and merges the PR.