Skip to content

[FIX] Fix saving workflows that contain a Rank widget#4289

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:fix-rank-settings
Dec 30, 2019
Merged

[FIX] Fix saving workflows that contain a Rank widget#4289
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:fix-rank-settings

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented Dec 20, 2019

Issue

Fixes #4285.

Description of changes

np.array cannot be saved as setting. selected_rows is now a list.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #4289 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4289      +/-   ##
==========================================
- Coverage   86.68%   86.68%   -0.01%     
==========================================
  Files         396      396              
  Lines       71510    71510              
==========================================
- Hits        61988    61987       -1     
- Misses       9522     9523       +1

@ajdapretnar ajdapretnar merged commit 3a2e8fc into biolab:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rank: Crash when saving a workflow

3 participants