Skip to content

[ENH] Heatmap: Restore ability to cluster larger datasets#4290

Merged
janezd merged 5 commits intobiolab:masterfrom
ales-erjavec:owheatmap-restore-clustering
Jan 17, 2020
Merged

[ENH] Heatmap: Restore ability to cluster larger datasets#4290
janezd merged 5 commits intobiolab:masterfrom
ales-erjavec:owheatmap-restore-clustering

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue

In gh-2000 'Heatmap' widget lost the ability to cluster larger datasets (>1000).

Description of changes

Restore the ability to cluster without opt. ordering to allow clustering on larger datasets.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Copy Markdown
Contributor

This works well for me, but pylint seems to be unhappy. Could we pacify it?

@ales-erjavec ales-erjavec force-pushed the owheatmap-restore-clustering branch from 66cde5a to 457b2b8 Compare January 7, 2020 12:20
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 7, 2020

Codecov Report

Merging #4290 into master will increase coverage by 0.05%.
The diff coverage is 94.35%.

@@            Coverage Diff             @@
##           master    #4290      +/-   ##
==========================================
+ Coverage   86.77%   86.82%   +0.05%     
==========================================
  Files         396      396              
  Lines       71550    71792     +242     
==========================================
+ Hits        62089    62336     +247     
+ Misses       9461     9456       -5

Avoud double text layout (for brect calc)
Add back option to select optimal ordering for clustering in order to
accommodate larger datasets.
@ales-erjavec ales-erjavec force-pushed the owheatmap-restore-clustering branch from 457b2b8 to 5200b1b Compare January 8, 2020 11:48
@Hrovatin
Copy link
Copy Markdown
Contributor

Hrovatin commented Jan 10, 2020

Seems to work fine.
However, when a Clustering option is selected it still shows None until the clustering has finished (so a few seconds). Maybe it could show Clustering upon selection (and colour it grey, as it is done now, while it is working). - So that it is immediately evident that the choice was successful. Same goes for None when clustering is removed.

@ales-erjavec ales-erjavec force-pushed the owheatmap-restore-clustering branch from 5200b1b to 09b56ac Compare January 13, 2020 13:30
@janezd janezd merged commit 737c444 into biolab:master Jan 17, 2020
@ales-erjavec ales-erjavec deleted the owheatmap-restore-clustering branch March 16, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants