[ENH] Heatmap: Restore ability to cluster larger datasets#4290
Merged
janezd merged 5 commits intobiolab:masterfrom Jan 17, 2020
Merged
[ENH] Heatmap: Restore ability to cluster larger datasets#4290janezd merged 5 commits intobiolab:masterfrom
janezd merged 5 commits intobiolab:masterfrom
Conversation
Contributor
|
This works well for me, but pylint seems to be unhappy. Could we pacify it? |
66cde5a to
457b2b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4290 +/- ##
==========================================
+ Coverage 86.77% 86.82% +0.05%
==========================================
Files 396 396
Lines 71550 71792 +242
==========================================
+ Hits 62089 62336 +247
+ Misses 9461 9456 -5 |
Avoud double text layout (for brect calc)
Add back option to select optimal ordering for clustering in order to accommodate larger datasets.
457b2b8 to
5200b1b
Compare
janezd
approved these changes
Jan 10, 2020
Contributor
|
Seems to work fine. |
5200b1b to
09b56ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In gh-2000 'Heatmap' widget lost the ability to cluster larger datasets (>1000).
Description of changes
Restore the ability to cluster without opt. ordering to allow clustering on larger datasets.
Includes