[FIX] Fix slow clear/delete in 'Heat Map' 'Hier. Clustering', 'Distance Map'#4365
Merged
thocevar merged 9 commits intobiolab:masterfrom Feb 3, 2020
Merged
[FIX] Fix slow clear/delete in 'Heat Map' 'Hier. Clustering', 'Distance Map'#4365thocevar merged 9 commits intobiolab:masterfrom
thocevar merged 9 commits intobiolab:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4365 +/- ##
==========================================
+ Coverage 87.13% 87.18% +0.05%
==========================================
Files 399 401 +2
Lines 72901 72931 +30
==========================================
+ Hits 63521 63585 +64
+ Misses 9380 9346 -34 |
2e558e3 to
829facd
Compare
829facd to
1a65176
Compare
Contributor
|
Heat map visualizations with a lot of rows (e.g., Adult dataset) are now besides being faster to delete also faster to construct. Distance map contains a quadratic number of elements anyway, therefore the difference is not that obvious. Hierarchical clustering must be doing something strange besides this. It should containt a linear number of elements but is still slow to delete. I don't think it solves #2663. |
... instead of installing individual filters on every item. This is a much better fix then biolabgh-4361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
owheatmap, owdistancemap and owhierarchicalclustering use QGraphicsLinearLayout to position text labels in a list. Clearing the QGraphicsLinearLayout however is slow (seems to be another quadratic time complexity).
Extract a more limited (but sufficient) TextListWidget from owsilhouetteplot and replace the use of QGraphicsLinearLayout.
Fixes gh-2663
Fixes gh-4349
Description of changes
Includes