Skip to content

[FIX] FeatureStatistics: Convert selected rows to list #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janezd merged 1 commit into from
Jan 31, 2020
Merged

[FIX] FeatureStatistics: Convert selected rows to list #4375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Orange/widgets/data/owfeaturestatistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,9 +900,9 @@ def set_info(self):
self.info_meta.setText('')

def on_select(self):
self.selected_rows = self.model.mapToSourceRows([
self.selected_rows = list(self.model.mapToSourceRows([
i.row() for i in self.table_view.selectionModel().selectedRows()
])
]))
self.commit()

def commit(self):
Expand Down
5 changes: 5 additions & 0 deletions Orange/widgets/data/tests/test_owfeaturestatistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime
import unittest
from collections import namedtuple
from functools import partial
from itertools import chain
Expand Down Expand Up @@ -461,3 +462,7 @@ def test_restores_previous_selection(self):
# Sending back the old data restores the selection
self.send_signal(self.widget.Inputs.data, self.data1)
self.assertEqual(len(self.widget.selected_rows), 2)


if __name__ == "__main__":
unittest.main()