[FIX] DataProjectionWidget: Update combos on new data#4405
Merged
janezd merged 2 commits intobiolab:masterfrom Feb 10, 2020
Merged
[FIX] DataProjectionWidget: Update combos on new data#4405janezd merged 2 commits intobiolab:masterfrom
janezd merged 2 commits intobiolab:masterfrom
Conversation
Contributor
|
At first I didn't understand why this fixes the problem. It is amazing that the widget worked with wrong variables in the model -- I guess it's only because we eliminated I added a test to convince myself that it's really about wrong variables in the model. And because it's prudent to have this test to prevent somebody from "re-optimizing" the code in the future. |
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
=======================================
Coverage 87.43% 87.44%
=======================================
Files 405 405
Lines 74061 74073 +12
=======================================
+ Hits 64758 64772 +14
+ Misses 9303 9301 -2 |
Contributor
Author
|
Thanks for the test. I tried to write one, but it kept passing with the old code. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4391
Description of changes
Includes