[ENH] Outliers: Offload work onto separate thread#4412
Merged
markotoplak merged 6 commits intobiolab:masterfrom Feb 21, 2020
Merged
[ENH] Outliers: Offload work onto separate thread#4412markotoplak merged 6 commits intobiolab:masterfrom
markotoplak merged 6 commits intobiolab:masterfrom
Conversation
e019f32 to
390108f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4412 +/- ##
==========================================
- Coverage 87.46% 87.45% -0.01%
==========================================
Files 405 405
Lines 73968 74118 +150
==========================================
+ Hits 64693 64817 +124
- Misses 9275 9301 +26 |
390108f to
32b48e8
Compare
Member
|
Thank you @VesnaT, I like it a lot! |
janezd
reviewed
Feb 14, 2020
Orange/base.py
Outdated
| return self.fit(X, Y, W) | ||
|
|
||
| def __call__(self, data): | ||
| def __call__(self, data, callback=None): |
Contributor
There was a problem hiding this comment.
I glanced over this PR. The only thing I don't like is the name of the argument. callback can be anything. Perhaps progress_callback? Longer, but more informative.
32b48e8 to
752abbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Responsive Outliers widget: the widget could make calculations in a separate thread to make Orange responsive.
Description of changes
progress_callbackfunction that serves as a wrapper function for callbacks. It allocates the corresponding proportion of the progress to the callback.Learnerto enable preprocessing interruption._OutlierModel.Includes