Skip to content

[FIX] File: Construct unique column names.#4420

Merged
janezd merged 2 commits intobiolab:masterfrom
thocevar:file-same_column_names
Feb 15, 2020
Merged

[FIX] File: Construct unique column names.#4420
janezd merged 2 commits intobiolab:masterfrom
thocevar:file-same_column_names

Conversation

@thocevar
Copy link
Contributor

Issue

Fixes #4381

Description of changes

File readers constructing a data table now rely on get_unique_names_duplicates from data.util instead of using their own similar logic.

Fixed get_unique_names_duplicates for cases where appending an index collides with an exiting name (['x', 'x', 'x (2)'] now returns ['x (1)', 'x (3)', 'x (2)'].

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9a4da3d). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4420   +/-   ##
=========================================
  Coverage          ?   87.46%           
=========================================
  Files             ?      405           
  Lines             ?    74132           
  Branches          ?        0           
=========================================
  Hits              ?    64841           
  Misses            ?     9291           
  Partials          ?        0

@janezd janezd merged commit 876e06e into biolab:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The File widget can be tricked into producing a table with non-unique column names

2 participants