[ENH] Scatter Plot: Replace combo box with search combo box#4447
Merged
lanzagar merged 2 commits intobiolab:masterfrom Mar 20, 2020
Merged
[ENH] Scatter Plot: Replace combo box with search combo box#4447lanzagar merged 2 commits intobiolab:masterfrom
lanzagar merged 2 commits intobiolab:masterfrom
Conversation
Contributor
|
Currently, this doesn't work. With File (iris) and Scatter Plot: |
PrimozGodec
force-pushed
the
search-combo-box
branch
from
2cac8e7 to
36bb7ea
Compare
Contributor
Author
|
@ajdapretnar I forgot to make a PR on widget-base, which need to be merged before. |
lanzagar
changed the title
Contributor
|
I actually like this. I much prefer it to overly long dropdowns. |
PrimozGodec
force-pushed
the
search-combo-box
branch
from
36bb7ea to
8a4e086
Compare
PrimozGodec
changed the title
PrimozGodec
changed the title
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
search-combo-box
branch
from
0995685 to
a31bad5
Compare
PrimozGodec
force-pushed
the
search-combo-box
branch
from
a31bad5 to
a8ec6e1
Compare
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4447 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 276 276
Lines 55299 55299
==========================================
- Hits 46198 46195 -3
- Misses 9101 9104 +3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When many attributes it is difficult to find the specific attribute to show.
Description of changes
Adding a search to the combo box in the scatter plot.
When this is merged I will start making the same changes in other widgets where required
Includes