[ENH] Fix printing values with too few decimals#4575
Merged
markotoplak merged 2 commits intobiolab:masterfrom Apr 2, 2020
Merged
[ENH] Fix printing values with too few decimals#4575markotoplak merged 2 commits intobiolab:masterfrom
markotoplak merged 2 commits intobiolab:masterfrom
Conversation
0aa054d to
78940cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
==========================================
- Coverage 83.59% 83.56% -0.03%
==========================================
Files 281 276 -5
Lines 56131 55331 -800
==========================================
- Hits 46921 46236 -685
+ Misses 9210 9095 -115 |
Member
|
This PR makes printing tables slower, but this operation does not need to be fast. It does not influence saving data, because the writer has its own formatter. Here are the differences between master and this branch: |
f6587cc to
c36d9bf
Compare
Contributor
Author
|
Excellent, thanks! And even these differences are not too large. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #4555.
Description of changes
Print two more decimals when the format is not
%gand the difference from the rounded values is outside numeric error.Includes