Skip to content

[FIX] Nomogram: Fix crash on Python 3.8#4591

Merged
PrimozGodec merged 2 commits intobiolab:masterfrom
lanzagar:fix-nomogram
Apr 1, 2020
Merged

[FIX] Nomogram: Fix crash on Python 3.8#4591
PrimozGodec merged 2 commits intobiolab:masterfrom
lanzagar:fix-nomogram

Conversation

@lanzagar
Copy link
Contributor

Issue

On py3.8 nomogram crashed for logistic regression models with:
TypeError: only integer scalar arrays can be converted to a scalar index

Description of changes

Iterate over actual coefficient values (numbers) instead of rows of a ndarray (which are still ndarrays) to get a proper boolean value for reverse.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #4591 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4591      +/-   ##
==========================================
- Coverage   83.61%   83.58%   -0.03%     
==========================================
  Files         281      276       -5     
  Lines       56189    55384     -805     
==========================================
- Hits        46982    46295     -687     
+ Misses       9207     9089     -118     

@PrimozGodec
Copy link
Contributor

Thank you. It works fine now.

@PrimozGodec PrimozGodec merged commit f7788e5 into biolab:master Apr 1, 2020
@lanzagar lanzagar deleted the fix-nomogram branch March 14, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants