[ENH] Gradient selection/parameters widget#4596
Merged
janezd merged 4 commits intobiolab:masterfrom May 8, 2020
Merged
Conversation
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
gradient-selection-widget
branch
2 times, most recently
from
e4fa0f9 to
667eba3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4596 +/- ##
==========================================
+ Coverage 83.66% 83.68% +0.02%
==========================================
Files 280 280
Lines 56322 56390 +68
==========================================
+ Hits 47121 47192 +71
+ Misses 9201 9198 -3 |
ales-erjavec
force-pushed
the
gradient-selection-widget
branch
from
667eba3 to
ce3f0a4
Compare
ales-erjavec
force-pushed
the
gradient-selection-widget
branch
2 times, most recently
from
4ab3628 to
2e7794d
Compare
ales-erjavec
changed the title
ales-erjavec
force-pushed
the
gradient-selection-widget
branch
from
2e7794d to
505995f
Compare
Contributor
|
Heatmap centers the scale if the palette is diverging. Moving just one slider (for diverging palettes) has no effect - adjustment of colors is equal to the smaller of the two sliders' adjustments.
|
Contributor
|
@ales-erjavec, I see I haven't merged this because I'm waiting for your response. I'm just pinging. "Merge as it is" is also a valid response. |
Contributor
Author
|
Sorry. I guess 'Merge as is' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Builds on gh-4593
Description of changes
Extract a color map selection combo box and thresholding sliders into a utility widget.
Includes