Skip to content

[FIX] Classification models output correct shapes#4602

Merged
VesnaT merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-svm
Apr 3, 2020
Merged

[FIX] Classification models output correct shapes#4602
VesnaT merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-svm

Conversation

@PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Mar 31, 2020

Description of changes
  • Support for all types of a sparse matrix in models __call__
  • Make data_to_model_domain public
  • Small clenup

This PR now includes essential changes that are required for the explain models widget and some cleanup. Other changes will be presented in separate PR.

@VesnaT and @lanzagar, your comments will be taken into account in the separate PR.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the fix-svm branch 7 times, most recently from 737054c to 60ded46 Compare April 1, 2020 09:26
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #4602 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4602      +/-   ##
==========================================
+ Coverage   83.61%   83.62%   +0.01%     
==========================================
  Files         281      276       -5     
  Lines       56189    55452     -737     
==========================================
- Hits        46982    46372     -610     
+ Misses       9207     9080     -127     

@PrimozGodec PrimozGodec changed the title [WIP][FIX] Classification models output correct shapes [FIX] Classification models output correct shapes Apr 1, 2020
@janezd janezd added the urgent Requires immediate action label Apr 3, 2020
@PrimozGodec PrimozGodec force-pushed the fix-svm branch 3 times, most recently from 1d00add to 66bd5ec Compare April 3, 2020 13:45
@PrimozGodec PrimozGodec requested a review from lanzagar April 3, 2020 13:50
@VesnaT VesnaT merged commit 7789901 into biolab:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

urgent Requires immediate action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants