[FIX] Several fixes in learners/models#4655
Merged
lanzagar merged 4 commits intobiolab:masterfrom Apr 30, 2020
Merged
Conversation
2fc3112 to
13c100b
Compare
8594496 to
f2f8f6e
Compare
f2f8f6e to
d3709fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #4655 +/- ##
========================================
Coverage 83.69% 83.69%
========================================
Files 280 275 -5
Lines 56447 55604 -843
========================================
- Hits 47244 46539 -705
+ Misses 9203 9065 -138 |
d3709fb to
c3b2c78
Compare
c3b2c78 to
6741b70
Compare
lanzagar
reviewed
Apr 30, 2020
6741b70 to
19baf96
Compare
19baf96 to
22061de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
data_to_model_domainwas introduced in a Model class it is duplicated in outliers.Description of changes
NuSVM: removed own predict function, adding missing dimensions is now handled by predict function on SklModeldata_to_model_domainremoved from outliers, added callbacks todata_to_model_domainin Model classIncludes