[ENH] Select Rows: Allow partial context matches#4740
Merged
lanzagar merged 1 commit intobiolab:masterfrom May 8, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4740 +/- ##
=======================================
Coverage 83.69% 83.70%
=======================================
Files 275 275
Lines 55620 55629 +9
=======================================
+ Hits 46551 46562 +11
+ Misses 9069 9067 -2 |
Contributor
Author
|
This PR won't have >= 95 % diff coverage because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes
Allow partial matches (but request matching at least one attribute) and remove non-matching conditions.
In case of multiple matches, take the match with the most matching variables.
Includes