Skip to content

[FIX] Fix colors for discrete variables with >256 values#4803

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:palettes_with_more_than_256_colors
May 22, 2020
Merged

[FIX] Fix colors for discrete variables with >256 values#4803
ajdapretnar merged 1 commit intobiolab:masterfrom
janezd:palettes_with_more_than_256_colors

Conversation

@janezd
Copy link
Contributor

@janezd janezd commented May 21, 2020

Issue

Fixes #4796 by cycling through colors of Glasbey palette. Nobody will notice that colors repeat.

Includes
  • Code changes
  • Tests

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #4803 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4803      +/-   ##
==========================================
- Coverage   83.86%   83.84%   -0.02%     
==========================================
  Files         281      276       -5     
  Lines       56804    55990     -814     
==========================================
- Hits        47638    46945     -693     
+ Misses       9166     9045     -121     

@ajdapretnar ajdapretnar merged commit 03cbf86 into biolab:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colors for more than 256 values crash

2 participants