Discrete variable: remove ordered attribute#4818
Merged
janezd merged 1 commit intobiolab:masterfrom Jun 12, 2020
Merged
Conversation
f2c611e to
029071f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
- Coverage 84.19% 84.18% -0.02%
==========================================
Files 282 277 -5
Lines 57355 56472 -883
==========================================
- Hits 48292 47541 -751
+ Misses 9063 8931 -132 |
janezd
reviewed
Jun 5, 2020
| def __init__( | ||
| self, name="", values=(), compute_value=None, sparse=False, | ||
| **kwargs | ||
| ): |
Contributor
There was a problem hiding this comment.
This is a bit dangerous: any call that passes compute_value as non-keyword argument will (possibly silently) fail. What about keeping ordered as an argument, but changing its default to None and the test if "ordered" in kwargs: to if ordered is not None?
Though: this is unlikely and, besides, such calls won't be fixed until the argument is actually removed and the calls will actually fail. We ignore warnings, including those about deprecations.
Contributor
Author
There was a problem hiding this comment.
You are right. Didn't think about this possibility. This solution was to avoid problems with __repr__ but now I fixed it differently.
340d71c to
7c222a2
Compare
OWMarkerGenes: settings migration and backward compatibility
7c222a2 to
98e95a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
As we already discussed in #4793 ordered attribute from the Discrete variable is not respected in most of the widgets anymore (except Feature Statistics), so it can be removed. Order defined in values tuple should be respected in any widget which needs order.
Description of changes
Includes