Skip to content

[FIX] Select Columns: Fix attributes sorting#4827

Merged
lanzagar merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-select-columns
May 28, 2020
Merged

[FIX] Select Columns: Fix attributes sorting#4827
lanzagar merged 1 commit intobiolab:masterfrom
PrimozGodec:fix-select-columns

Conversation

@PrimozGodec
Copy link
Copy Markdown
Contributor

Issue

Select Columns widget fails when getting data with additional attributes.

Description of changes

Fixed sorting of attributes that it does not compare Variables while sorting.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Select column: Fix attributes sorting Select columns: Fix attributes sorting May 28, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2020

Codecov Report

Merging #4827 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   84.01%   83.99%   -0.02%     
==========================================
  Files         281      276       -5     
  Lines       56897    56070     -827     
==========================================
- Hits        47802    47098     -704     
+ Misses       9095     8972     -123     

@lanzagar lanzagar changed the title Select columns: Fix attributes sorting [FIX] Select Columns: Fix attributes sorting May 28, 2020
@lanzagar lanzagar merged commit f1ea981 into biolab:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants