[ENH] CSV Import: guess data types#4838
Merged
ales-erjavec merged 1 commit intobiolab:masterfrom Jun 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4838 +/- ##
==========================================
+ Coverage 84.01% 84.07% +0.05%
==========================================
Files 281 277 -4
Lines 56901 56487 -414
==========================================
- Hits 47804 47490 -314
+ Misses 9097 8997 -100 |
Contributor
I think it is ok. |
Contributor
Author
|
Ok. Then I will write a few tests before it is merged. |
PrimozGodec
force-pushed
the
csvimport-autovariable
branch
2 times, most recently
from
2d5cdc5 to
e970535
Compare
PrimozGodec
force-pushed
the
csvimport-autovariable
branch
from
e970535 to
9c19f2f
Compare
ales-erjavec
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Implements #4794
Description of changes
Implemented guessing strategy for CSV import which should match the strategy in
io_utils.guess_data_type.This PR adds another iteration over the columns. For each column, it checks for the data type according to data. Complex operations here are:
@ales-erjavec is this kind of guessing acceptable or would decrease the performance of the widget too much?
TODO
Includes