[ENH] Louvain Clustering: Add cosine similarity#4864
Merged
pavlin-policar merged 1 commit intobiolab:masterfrom Jun 20, 2020
Merged
[ENH] Louvain Clustering: Add cosine similarity#4864pavlin-policar merged 1 commit intobiolab:masterfrom
pavlin-policar merged 1 commit intobiolab:masterfrom
Conversation
Contributor
Author
|
@pavlin-policar, I didn't really read the entire widget's code, but it seems that it would suffice to normalize the data and change the metric in Am I correct? |
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #4864 +/- ##
==========================================
- Coverage 84.17% 84.17% -0.01%
==========================================
Files 277 277
Lines 56541 56503 -38
==========================================
- Hits 47596 47564 -32
+ Misses 8945 8939 -6 |
Collaborator
Yes, that's right. We build a graph, and the edges are weighted with the Jaccard coefficient of shared nearest neighbors between points. Distances are not used anywhere. This codecov is doing strange things again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @pavlin-policar in a comment to #4855, cosine distance can be computed as Euclidean on row-normalized data, because we care only about ranking. This allows NearestNeighbours to use ball trees.
Includes