[ENH] Replace listViews with searchable listViews#4924
Merged
janezd merged 2 commits intobiolab:masterfrom Sep 18, 2020
Merged
Conversation
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
list-view-search
branch
2 times, most recently
from
09182e6 to
d065e5a
Compare
PrimozGodec
force-pushed
the
list-view-search
branch
from
d065e5a to
f8b2101
Compare
Codecov Report
@@ Coverage Diff @@
## master #4924 +/- ##
==========================================
+ Coverage 84.47% 84.63% +0.15%
==========================================
Files 283 284 +1
Lines 58344 58819 +475
==========================================
+ Hits 49289 49781 +492
+ Misses 9055 9038 -17 |
Contributor
|
This can now be reviewed and possibly merged, right? (Answer "no" or just remove "WIP".) |
PrimozGodec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ListViews do not have a filter
Description of changes
Replacing listViews with a searchable list view
It must not merged before https://github.com/biolab/orange-widget-base is released.
Includes