Skip to content

Fix discretize default cutpoints restore#4970

Merged
janezd merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/discretize-default-cutpoints-save
Sep 11, 2020
Merged

Fix discretize default cutpoints restore#4970
janezd merged 3 commits intobiolab:masterfrom
ales-erjavec:fixes/discretize-default-cutpoints-save

Conversation

@ales-erjavec
Copy link
Copy Markdown
Contributor

Issue

Fixup for #4929

Default custom cut points are not restored due to an errant assignment in constructor

Description of changes
  • Remove assign to 'default_cutpoints' in constructor
  • Also enable/disable edit line entry to match the selected method.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2020

Codecov Report

Merging #4970 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4970   +/-   ##
=======================================
  Coverage   84.49%   84.50%           
=======================================
  Files         283      283           
  Lines       58234    58290   +56     
=======================================
+ Hits        49204    49257   +53     
- Misses       9030     9033    +3     

@janezd janezd self-assigned this Sep 11, 2020
@janezd janezd merged commit a9c7853 into biolab:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants