[FIX] impute: Remove class vars from input data for ReplaceUnknownsModel#5083
Merged
janezd merged 1 commit intobiolab:masterfrom Nov 13, 2020
Merged
Conversation
`ReplaceUnknownsModel` did not work on input dataset with `class_vars` since biolabgh-3925 due to error raised by backmapping.
Codecov Report
@@ Coverage Diff @@
## master #5083 +/- ##
=======================================
Coverage 84.74% 84.74%
=======================================
Files 286 286
Lines 60036 60037 +1
=======================================
+ Hits 50876 50878 +2
+ Misses 9160 9159 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
impute.Modeldoes not work on input dataset withclass_varssince gh-3925 due to error raised by backmapping.Description of changes
Remove class vars from input data for ReplaceUnknownsModel
Includes